fix: resolve UI accessibility, hydration, and semantic HTML issues #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amannhq
commented
Oct 25, 2025
amannhq
commented
- Add suppressHydrationWarning to body element to handle browser extension attributes
- Add DialogTitle components to graph-dialog and add-memory dialog for screen reader accessibility
- Convert SVG attributes to React/JSX camelCase format (strokeWidth, strokeLinecap, strokeLinejoin, clipPath)
- Replace div role="button" with semantic button element in chat sidebar
- Add biome-ignore comment for array index keys in text-effect animation (position is stable)
- Add localhost bypass in middleware to prevent authentication redirect loops during development
- Add lang="en" attribute to global-error.tsx html element
- Clean up duplicate CSS classes in add-memory component
- Add suppressHydrationWarning to body element to handle browser extension attributes - Add DialogTitle components to graph-dialog and add-memory dialog for screen reader accessibility - Convert SVG attributes to React/JSX camelCase format (strokeWidth, strokeLinecap, strokeLinejoin, clipPath) - Replace div role="button" with semantic button element in chat sidebar - Add biome-ignore comment for array index keys in text-effect animation (position is stable) - Add localhost bypass in middleware to prevent authentication redirect loops during development - Add lang="en" attribute to global-error.tsx html element - Clean up duplicate CSS classes in add-memory component
How to use the Graphite Merge QueueAdd the label Main to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
apps/web/middleware.ts
Outdated
| console.debug("[MIDDLEWARE] Path:", url.pathname) | ||
| console.debug("[MIDDLEWARE] Method:", request.method) | ||
|
|
||
| if (url.hostname === "localhost") { |
Member
There was a problem hiding this comment.
please remove this condition in middleware. when you running in the local you can have in middleware
MaheshtheDev
approved these changes
Oct 28, 2025
Member
MaheshtheDev
left a comment
MaheshtheDev
left a comment
There was a problem hiding this comment.
thanks for the contributions, looks good to me
|
|
nexxeln
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.