Implement dry run mode #274
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant Options
participant CD/DVD Dumper
User->>CLI: Launch with --dry-run
CLI->>Options: Parse arguments
Options-->>CLI: Set dry_run = true
CLI->>CD/DVD Dumper: Start dump operation
CD/DVD Dumper->>CD/DVD Dumper: Check dry_run
alt dry_run is true
CD/DVD Dumper-->>CLI: Return immediately (no user data dumped)
else dry_run is false
CD/DVD Dumper->>CD/DVD Dumper: Proceed with normal dumping
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (8)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Many thanks for this, this sounds perfect as a solution for #273 etc. The only thing I'm a little wary of is the name "dry run". In other applications, dry run would normally not cause any writes to disk, but for redumper, it will. Maybe "--no-image" or something? |
2 participants
Adds a new
--dry-runoption that skips dumping main user data, only performing pre-dump checks and saving auxiliary files.For DVDs, it will get the .manufacturer/.physical, and for Xbox it will also get the .security file.
For CDs, it will get the TOC, and the FULLTOC/PMA/ATIP/CDTEXT when applicable.
It can be used with
redumper dump --dry-runas well as safely used in aggregate mode,redumper --dry-run. When run in aggregate mode, the xbox auxiliary files are still split into DMI/PFI/SS, which is a request by #273 and other dumpers.The use case is for people who want to get the auxiliary files from discs they have already dumped (e.g. getting fixed XGD3 SS, or DMI for DRM DVDs), are only interested in the auxiliary files (e.g. using redumper as part of a larger workflow), or want to get the TOC from one disc to then force refine another disc.