Fly.io development #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2025 00:10
jsierles
force-pushed
the
js-flyio-dev
branch
from
a98416f to
23c9ae0
Compare
added 13 commits
February 21, 2025 00:19
This reverts commit d3fbd57.
| if pgbackrest := postgresCluster.Spec.Backups.PGBackRest; pgbackrest.RepoHost != nil && | ||
| len(pgbackrest.RepoHost.Sidecars) > 0 { | ||
| // Add each sidecar container to the pod spec | ||
| repo.Spec.Template.Spec.Containers = append( |
There was a problem hiding this comment.
fwiw, you'd actually want to add this to initContainers and have a restart policy set to Always for the container. that ensures it actually starts before the main program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a development branch for merging fixes into. This is where we should take releases for testing in FKS clusters.