Skip to content

references updated for 2nd edition of sc book #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

elifieldsteel
Copy link
Contributor

Modified website data to reflect publication of 2nd edition of SC book. Includes edits to gallery yaml file as well as blog post. Also included two new image files of 2nd edition book cover.

@capital-G
Copy link
Contributor

Hey, thanks for the PR :) The PR is fine as is, but maybe we could also write a new blog post instead of modifying the post of the first edition - what do you think? Would be great to get a bit more blog-posts on the website again ;)

@elifieldsteel
Copy link
Contributor Author

Hey, thanks for the PR :) The PR is fine as is, but maybe we could also write a new blog post instead of modifying the post of the first edition - what do you think? Would be great to get a bit more blog-posts on the website again ;)

That's a good idea. I'm probably not the most qualified to write such a blog post. I'll reach out to Scott Wilson and see if he'd be willing to write something up. Also my knowledge of github workflow is limited, I only have a grasp on the absolute basics...once I have the text for a new blog post, would I just continue editing this branch locally and make another commit/PR?

@capital-G
Copy link
Contributor

I'll reach out to Scott Wilson and see if he'd be willing to write something up.

That sounds like a good idea :) Maybe we can still change the Gallery image and link in this PR?

I only have a grasp on the absolute basics...once I have the text for a new blog post, would I just continue editing this branch locally and make another commit/PR?

Since the changes are not vast so far it is probably easiest to do a soft reset by rolling back one commit while on the branch (git reset HEAD~1), re-stage the changed files (so mabye do not stage the changes in _posts/2011-04-19-the-supercollider-book.md), commit the staged changes and perform a force push via git push --force to overwrite the remote changes on GitHub with your local changes.

Alternative: Just start a new PR from the main branch and close this PR when creating the new PR.

BTW - I found that MIT-supercollider-book-v2.jpg is part of the commit but is not referenced anywhere on the website - so maybe not commit this one as well or reference it somewhere ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants