Skip to content

ScatterView: remove deprecations, modernize #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ScatterView: remove deprecations, modernize #36

wants to merge 1 commit into from

Conversation

elgiano
Copy link

@elgiano elgiano commented Apr 15, 2022

Removing deprecated calls for the ScatterView:

  • relativeOrigin from wslib
  • calls to GUI

see also https://scsynth.org/t/problems-with-scatterview/5701

dyfer
dyfer previously approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@dyfer dyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dyfer dyfer dismissed their stale review April 17, 2022 00:03

I realized this overlaps with PR #35

@dyfer
Copy link
Contributor

dyfer commented Apr 17, 2022

On a second look #35 includes these fixes and has less whitespace change. As it was submitted first, I think we should merge that one. Is that OK with you @elgiano ?
Also, after testing more ScatterPlot -highlightRange seems to not work in this PR.

@elgiano
Copy link
Author

elgiano commented Apr 18, 2022

Perfect, sorry I missed it!
Closing in favor of #35

@elgiano elgiano closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyfer dyfer dyfer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elgiano @dyfer