chore(deps): migrate dependency from cli v1 to clipkg module #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 8. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v8) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
savme
commented
Nov 9, 2025
| OrganizationId: data.OrganizationId.ValueString(), | ||
| Name: data.Name.ValueString(), | ||
| DbPass: data.DatabasePassword.ValueString(), | ||
| Region: api.V1CreateProjectBodyDtoRegion(data.Region.ValueString()), |
Author
There was a problem hiding this comment.
Region is deprecated in favor of RegionSelection
Comment on lines
+439
to
+451
| if f.CanInterface() { | ||
| if v, ok := f.Interface().(interface { | ||
| IsNull() bool | ||
| IsSpecified() bool | ||
| }); ok { | ||
| if !v.IsSpecified() { | ||
| continue | ||
| } | ||
|
|
||
| if v.IsNull() { | ||
| continue | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
Field types changed *T -> nullable.Nullable[T]. This filters null/unspecified fields to match old pointer behavior
| ImportStateVerify: true, | ||
| ResourceName: "supabase_settings.production", | ||
| ImportState: true, | ||
| ImportStateCheck: func(is []*terraform.InstanceState) error { |
Author
There was a problem hiding this comment.
Switched to using ImportStateCheck because marshalling zero-initialized Nullable fields in the mock causes all fields to appear in the response with zero values rather than as null.
This keeps the test focused on the fields explicitly set in the mock for now; happy to revisit if we find a better approach later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Dependency update
What is the new behavior?
Latest API client is used.
Additional context
This PR needs #234 to build. Will rebase onto main after it gets merged.
Please ignore golangci-related changes.