Skip to content

added test for issue 1470 #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

georgRusanov
Copy link
Contributor

What kind of change does this PR introduce?

test for issue 1470

@mandarini
Copy link
Contributor

@georgRusanov can you please rebase the branch with latest master? Let me know when this is ready for review! Thank you!!!!

@mandarini mandarini self-requested a review August 1, 2025 08:16
@georgRusanov
Copy link
Contributor Author

georgRusanov commented Aug 1, 2025

@mandarini Hello
This and the next PRs are just examples for the issue 1470. They have the same test, but with different relatime-js versions.
They are show that with relatime-js older than 2.11.12 and without(unavailable or incompatible for some cloud environments) isows, realtimeClient will not be created, but it will be created with 2.11.12.
I don't think it should be merged. At least, this one will fail all the time while the issue exists. The second one will be closed in future.

@mandarini
Copy link
Contributor

@georgRusanov once this is merged and released, the tests should be passing, and we can merge your PR. Thank you for adding those tests!

@mandarini mandarini self-assigned this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants