fix: Ensure Content-Disposition Header conforms to RFC6266 #735
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
When a filename is specified, the
content-disposition
header is added. Currently the header will have content like this:RFC6266 specifies the valid formats for this header, and a trailing semi-colon is not allowed per the grammar at https://datatracker.ietf.org/doc/html/rfc6266#page-4
I was prompted to raise this PR when I ran into the same issue discussed here: jshttp/content-disposition#11
What is the new behavior?
The PR removes the trailing semi-colon and updates the test for it.