Skip to content

Allow Setting Annotations for All Services / Deployments #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Varantha
Copy link

@Varantha Varantha commented Jul 6, 2025

What kind of change does this PR introduce?

New functionality:

  • allow setting annotations for all service and deployment resources
  • expose deployment.annotations and service.annotations keys for all templates in values.yaml

What is the current behavior?

You are unable to set annotations on any services / deployments within this chart

What is the new behavior?

Users can now optionally include annotations for services / deployments if they wish

Additional context

I have a few annotations that I want to add to services.
For example for deployments I'd like to be able to reload them with Reloader
For services I'd like to annotate db with a DNS hostname using external-dns

@Varantha
Copy link
Author

Okay, I think I've fixed the tests now?

I'm confused at the process to contribute, it says to run sh build.sh but then I don't see any other versions in the ./build directory, nor updates in the ./index.yaml file. So I've just removed them and bumped up the Chart.yaml version. Let me know if there's something else I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant