Fix Kong wrapper config script sed delimiter to allow using Base64 values #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
If any of the env vars among
SUPABASE_ANON_KEY,SUPABASE_SERVICE_KEY,DASHBOARD_USERNAMEorDASHBOARD_PASSWORDfor Kong happen to be Base64-encoded and/or contain forward slashes,sedwill fail to process them into a template, throwing a parsing errorWhat is the new behavior?
With delimiters replaces by
|symbols, these may fix an aforementioned issue, but it would become undesirable to use this symbol in any of the environment variablesAdditional context
By all means, it's a quick and dirty fix, as it substitutes one illegal symbol for a less common one. A better fix may be in order that would not rely on using any of the symbols that may break the substitution