Skip to content

feat(person): implement person card list view for mobile viewports #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

daliborstakic
Copy link

No description provided.

@matijakljajic
Copy link
Contributor

From a UX perspective, it might be better if clicking the action buttons (Admit, Release, etc.) didn’t also open up the accordion. You could try adjusting the <slot /> placement in accordion-trigger.svelte. Not entirely sure how it works under the hood at this moment, but maybe that's the way to delegate the "open accordion" behavior to just the chevron icon instead of the whole item tab, even if it’s a bit of a hack.

That's the first thing that comes to mind at least regarding that.

@matijakljajic
Copy link
Contributor

Everything else seems clean, I noticed I should probably rewrite pages to not use shadcn cards for the content except for the login pages. :P

@daliborstakic
Copy link
Author

From a UX perspective, it might be better if clicking the action buttons (Admit, Release, etc.) didn’t also open up the accordion. You could try adjusting the <slot /> placement in accordion-trigger.svelte. Not entirely sure how it works under the hood at this moment, but maybe that's the way to delegate the "open accordion" behavior to just the chevron icon instead of the whole item tab, even if it’s a bit of a hack.

That's the first thing that comes to mind at least regarding that.

It's the HTML event, I just need to add event.stopPropagation to all onclick event so that the event isn't passed down to all components

@daliborstakic daliborstakic reopened this May 26, 2025
@daliborstakic daliborstakic self-assigned this May 26, 2025
@daliborstakic daliborstakic marked this pull request as ready for review June 3, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants