Skip to content

Conversation

@DFelten
Copy link
Contributor

@DFelten DFelten commented Aug 2, 2025

Since minSize is deprecated it's no longer necessary to add a default for this. The default has to be removed anyway, otherwise the new value minimumSize cannot be set. There is an assert in the CupertinoButton that only allows one of the two values.

The assert:

assert(minimumSize == null || minSize == null)

Without my changes, there is an exception if we try to use minimumSize. It's the same for other buttons.

Example:

PlatformIconButton(
      icon: const Icon(Icons.sort),
      cupertino: (_, _) => CupertinoIconButtonData(minimumSize: Size.square(34)),
    );

@DFelten DFelten changed the title fix: Remove default for minSize in platform_icon_button fix: Remove default for minSize in platform buttons Aug 2, 2025
@naamapps
Copy link

naamapps commented Aug 7, 2025

@aqwert Can you please approve and deploy this fix? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants