Skip to content

Conversation

@M-Ahal
Copy link

@M-Ahal M-Ahal commented Apr 1, 2025

  1. Many data classes could have had const constructors but didn't. I added it for all.
    • some were also missing final params
    • Most BaseData could be const, and that was preventing extend MaterialData... and CupertinoData... from being const
    • These performance updates did percolate down to the examples
  2. Removed an unimplemented todo file
  3. Migrated the example to use the new build system
    • Regenerated the project and added back the lib/**, pubspec.yaml, README.md.
    • Ran build on XCode to generate any remaining files
  4. Added FVM to gitignore + removed from VCS
    • Link to /User/Johnstone/.fvm/... was in VCS, so that should not be there
    • pubspec.yaml had pinned a min flutter: ">=3.29.0", but this did not reflect in the "3.24.0" in the fvm_config.json. It's better to allow a developer to use their own FVM version, and set min and max in the pubspec directly

M-Ahal added 2 commits July 24, 2025 15:00
# Conflicts:
#	lib/src/platform.dart
#	lib/src/platform_alert_dialog.dart
#	lib/src/platform_app_bar.dart
#	lib/src/platform_date_picker.dart
#	lib/src/platform_elevated_button.dart
#	lib/src/platform_icon_button.dart
#	lib/src/platform_nav_bar.dart
#	lib/src/platform_sliver_app_bar.dart
#	lib/src/platform_tab_scaffold.dart
#	lib/src/platform_text.dart
#	lib/src/platform_text_button.dart
#	lib/src/platform_theme.dart
@M-Ahal
Copy link
Author

M-Ahal commented Aug 11, 2025

@aqwert is there something left or unclear. This is a relatively small PR. I'd like to fix up something if broken. The const classes are really needed.
Please lmk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant