Skip to content

Optimized class name #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimized class name #431

wants to merge 1 commit into from

Conversation

@bookshiyi
Copy link
Contributor

@bookshiyi bookshiyi commented Jul 19, 2023

  1. MaterialProgressIndicatorData -> MaterialCircularProgressIndicatorData

  2. CupertinoProgressIndicatorData -> CupertinoCircularProgressIndicatorData

@bookshiyi
Optimized class name
54198b1 
1. MaterialProgressIndicatorData ->  MaterialCircularProgressIndicatorData

2. CupertinoProgressIndicatorData -> CupertinoCircularProgressIndicatorData
@EchoEllet
Copy link

EchoEllet commented Oct 20, 2023

Hi, your changes make sense but I wonder why no one accepting them.

@bookshiyi
Copy link
Contributor Author

bookshiyi commented Oct 21, 2023 •
edited
Loading

Hi, your changes make sense but I wonder why no one accepting them.

I have submitted multiple PRs but have never received a response since July. Hope the maintainer can see and deal with it as soon as possible.

@EchoEllet
Copy link

EchoEllet commented Oct 21, 2023

Hi, your changes make sense but I wonder why no one accepting them.

I have submitted multiple PRs but have never received a response since July. Hope the master can see and deal with it as soon as possible.

Me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bookshiyi @EchoEllet