Issue 111 - Support CommandGroups in CommandTester #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rothso
changed the title
|
@rhauch What do you think? We never provided feedback on the original issue, but this seems like a feature that should be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #111 and moves the
buildRunnermethod from Scheduler into CommandRunner so CommandTester can also correctly execute CommandGroups.To keep the code clean, I've adjusted the CommandRunner to expose two static builders:
CommandRunner#create(Context, Command)CommandRunner#create(Command)These builders call into
buildRunner. After some refactoring, I was left with only two CommandRunner constructors. Both are only used by thebuildRunnerso I made them private. Regression/integration tests included. Let me know what you think and if there's anything you'd like me to change. Thanks!