Skip to content

Fix Xcode 15 Link New Payment Snapshot Tests #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix Xcode 15 Link New Payment Snapshot Tests #5669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54f6668
add missing iOS 26 tests tag
jkelle-stripe Oct 6, 2025
480c8cf
run ci tests on xcode 15
jkelle-stripe Oct 6, 2025
8cec379
unskip tests
jkelle-stripe Oct 6, 2025
848d4b9
update test plan output
jkelle-stripe Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 65 additions & 14 deletions Stripe/AllStripeFrameworks-iOS26.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,34 @@
},
{
"selectedTests": [
"CVCReconfirmationViewControllerSnapshotTest/testCVCRecollectionScreen()",
"FormElementSnapshotTest/testDefaultTheme()",
"LinkHintMessageViewSnapshotTests/testLongMessageWithWrapping()",
"LinkHintMessageViewSnapshotTests/testLongMessageWithWrappingErrorStyle()",
"LinkHintMessageViewSnapshotTests/testNormalLengthMessage()",
"LinkHintMessageViewSnapshotTests/testNormalLengthMessageErrorStyle()",
"LinkHintMessageViewSnapshotTests/testOutlinedStyle()",
"LinkPaymentMethodFormElementSnapshotTests/testBillingDetailsUpdate()",
"LinkPaymentMethodFormElementSnapshotTests/testBillingDetailsUpdateForBankAccount()",
"LinkPaymentMethodFormElementSnapshotTests/testBillingDetailsUpdateWithFullBillingDetails()",
"LinkPaymentMethodFormElementSnapshotTests/testBillingDetailsUpdateWithPartialBillingDetails()",
"LinkPaymentMethodFormElementSnapshotTests/testCoBrandedCard()",
"LinkPaymentMethodFormElementSnapshotTests/testDefault()",
"LinkPaymentMethodFormElementSnapshotTests/testNonDefault()",
"LinkPaymentMethodPickerSnapshotTests/testEmpty()",
"LinkPaymentMethodPickerSnapshotTests/testExpanded()",
"LinkPaymentMethodPickerSnapshotTests/testFirstOptionUnsupported()",
"LinkPaymentMethodPickerSnapshotTests/testLongEmail()",
"LinkPaymentMethodPickerSnapshotTests/testLongerEmail()",
"LinkPaymentMethodPickerSnapshotTests/testNormal()",
"LinkPaymentMethodPickerSnapshotTests/testUnsupportedBankAccount()",
"LinkPaymentMethodPickerSnapshotTests/testUnsupportedSelectedNotCollapsed()",
"LinkSignUpViewControllerSnapshotTests/testEmptyView()",
"LinkSignUpViewControllerSnapshotTests/testWithEmail()",
"PayWithLinkViewController_NewPaymentViewControllerSnapshotTests/testIsAddingFirstPaymentMethod()",
"PayWithLinkViewController_NewPaymentViewControllerSnapshotTests/testIsNotAddingFirstPaymentMethod()",
"PaymentMethodTypeCollectionViewCellSnapshotTests/test_withPromoBadge()",
"PaymentMethodTypeCollectionViewCellSnapshotTests/test_withPromoBadge_customAppearance()",
"PaymentSheetFlowControllerViewControllerSnapshotTests/testCVCRecollectionScreen()",
"PaymentSheetFlowControllerViewControllerSnapshotTests/testCVVRecollectionScreen()",
"PaymentSheetFlowControllerViewControllerSnapshotTests/testDirectToCardScan()",
"PaymentSheetFlowControllerViewControllerSnapshotTests/testNewScreen_customCTA()",
"PaymentSheetFlowControllerViewControllerSnapshotTests/testSavedScreen_SEPA_debit()",
Expand All @@ -47,16 +71,9 @@
"SavedPaymentOptionsViewControllerSnapshotTests/test_all_saved_pms_and_apple_pay_and_link_custom_appearance()",
"SavedPaymentOptionsViewControllerSnapshotTests/test_all_saved_pms_and_apple_pay_and_link_dark()",
"SavedPaymentOptionsViewControllerSnapshotTests/test_all_saved_pms_and_apple_pay_and_link_default_badge()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleCard_UpdatePaymentMethodViewControllerAppearance()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleCard_UpdatePaymentMethodViewControllerCanUpdateLightMode()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleCard_UpdatePaymentMethodViewControllerDarkMode()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleCard_UpdatePaymentMethodViewControllerLightMode()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleSEPADebit_UpdatePaymentMethodViewControllerAppearance()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleSEPADebit_UpdatePaymentMethodViewControllerDarkMode()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleSEPADebit_UpdatePaymentMethodViewControllerLightMode()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleUSBankAccount_UpdatePaymentMethodViewControllerAppearance()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleUSBankAccount_UpdatePaymentMethodViewControllerDarkMode()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_EmbeddedSingleUSBankAccount_UpdatePaymentMethodViewControllerLightMode()",
"SavedPaymentOptionsViewControllerSnapshotTests/test_cvc_recollection()",
"SavedPaymentOptionsViewControllerSnapshotTests/test_cvc_recollection_dark()",
"SectionElementSnapshotTest/testDisabledState()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_UpdatePaymentMethodViewControllerAppearance()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_UpdatePaymentMethodViewControllerCanUpdateAppearance()",
"UpdatePaymentMethodViewControllerSnapshotTests/test_UpdatePaymentMethodViewControllerCanUpdateExpiredCard()",
Expand Down Expand Up @@ -97,7 +114,14 @@
"VerticalSavedPaymentMethodsViewControllerSnapshotTests/test_VerticalSavedPaymentMethodsViewControllerSnapshotTestsAppearance()",
"VerticalSavedPaymentMethodsViewControllerSnapshotTests/test_VerticalSavedPaymentMethodsViewControllerSnapshotTestsLightMode()",
"VerticalSavedPaymentMethodsViewControllerSnapshotTests/test_VerticalSavedPaymentOptionsViewControllerSnapshotTestsDarkMode()",
"VerticalSavedPaymentMethodsViewControllerSnapshotTests/test_VerticalSavedPaymentOptionsViewControllerSnapshotTestsDefaultBadge()"
"VerticalSavedPaymentMethodsViewControllerSnapshotTests/test_VerticalSavedPaymentOptionsViewControllerSnapshotTestsDefaultBadge()",
"WalletViewControllerSnapshotTests/testAlternativeCTA()",
"WalletViewControllerSnapshotTests/testDefault()",
"WalletViewControllerSnapshotTests/testWithApplePay()",
"WalletViewControllerSnapshotTests/testWithCvcRecollection()",
"WalletViewControllerSnapshotTests/testWithError()",
"WalletViewControllerSnapshotTests/testWithExpiryDateRecollection()",
"WalletViewControllerSnapshotTests/testWithMandate()"
],
"target": {
"containerPath": "container:StripePaymentSheet/StripePaymentSheet.xcodeproj",
Expand Down Expand Up @@ -177,6 +201,9 @@
},
{
"selectedTests": [
"AutoCompleteViewControllerSnapshotTests/testAutoCompleteViewController()",
"AutoCompleteViewControllerSnapshotTests/testAutoCompleteViewController_appearance()",
"AutoCompleteViewControllerSnapshotTests/testAutoCompleteViewController_darkMode()",
"ConfirmButtonSnapshotTests/testConfirmButton()",
"ConfirmButtonSnapshotTests/testConfirmButtonBackgroundColor()",
"ConfirmButtonSnapshotTests/testConfirmButtonCustomFont()",
Expand All @@ -190,9 +217,33 @@
"ConfirmButtonSnapshotTests/testConfirmButtonInLinkUI()",
"ConfirmButtonSnapshotTests/testConfirmButtonSuccessColor()",
"ConfirmButtonTests/testBuyButtonShouldAutomaticallyAdjustItsForegroundColor()",
"LinkInlineSignupElementSnapshotTests/testDefaultOptIn_fully_preFilled()",
"LinkInlineSignupElementSnapshotTests/testDefaultOptIn_fully_preFilled_longEmail()",
"LinkInlineSignupElementSnapshotTests/testDefaultOptIn_partially_preFilled()",
"LinkInlineSignupElementSnapshotTests/testDefaultState()",
"LinkInlineSignupElementSnapshotTests/testDefaultState_textFieldsOnly()",
"LinkInlineSignupElementSnapshotTests/testExpandedState()",
"LinkInlineSignupElementSnapshotTests/testExpandedState_nonUS()",
"LinkInlineSignupElementSnapshotTests/testExpandedState_nonUS_preFilled()",
"LinkInlineSignupElementSnapshotTests/testExpandedState_nonUS_preFilled_textFieldsOnly()",
"LinkInlineSignupElementSnapshotTests/testExpandedState_nonUS_textFieldsOnly()",
"LinkInlineSignupElementSnapshotTests/testExpandedState_textFieldsOnly()",
"LinkInlineSignupElementSnapshotTests/testSignupOptInFeatureEnabled_unchecked()",
"RemoveButtonSnapshotTests/testRemoveButton()",
"RemoveButtonSnapshotTests/testRemoveButtonCustomFontScales()",
"RemoveButtonSnapshotTests/testRemoveButtonCustomSheetBackgroundAndDanger()"
"RemoveButtonSnapshotTests/testRemoveButtonCustomSheetBackgroundAndDanger()",
"RemoveButtonSnapshotTests/testRemoveButtonCustomZeroCornerRadius()",
"WalletHeaderViewSnapshotTests/testAdaptiveElements()",
"WalletHeaderViewSnapshotTests/testAdaptiveElementsWithCustomApplePayCta()",
"WalletHeaderViewSnapshotTests/testAllButtons()",
"WalletHeaderViewSnapshotTests/testAllButtonsSetupIntent()",
"WalletHeaderViewSnapshotTests/testAllButtonsWithCustomApplePayCta()",
"WalletHeaderViewSnapshotTests/testApplePayButton()",
"WalletHeaderViewSnapshotTests/testApplePayButtonWithCustomCta()",
"WalletHeaderViewSnapshotTests/testCustomCornerRadius()",
"WalletHeaderViewSnapshotTests/testCustomFont()",
"WalletHeaderViewSnapshotTests/testCustomFontScales()",
"WalletHeaderViewSnapshotTests/testLinkButton()"
],
"target": {
"containerPath": "container:Stripe/Stripe.xcodeproj",
Expand Down
1 change: 1 addition & 0 deletions ...s/PaymentSheet/Link/PayWithLinkViewController-NewPaymentViewControllerSnapshotTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import StripeCoreTestUtils
@testable@_spi(STP) import StripePaymentSheet
@testable@_spi(STP) import StripeUICore

// @iOS26
class PayWithLinkViewController_NewPaymentViewControllerSnapshotTests: STPSnapshotTestCase {

override func setUp() {
Expand Down
1 change: 1 addition & 0 deletions bitrise.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ stages:
- ui-tests-5: {}
- integration-all: {}
- lokalise-upload: {}
- legacy-tests-15: {}
stage-releases-run-all:
workflows:
- framework-tests-no-mocks: {}
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ platform :ios do

Dir.chdir('..') do
schemes.each do |scheme|
sh("./ci_scripts/test.rb --scheme '#{scheme}' --device '#{options[:device]}' --version #{options[:version]} --skip-snapshot-tests --skip-test 'StripePaymentSheetTests/PayWithLinkViewController_NewPaymentViewControllerSnapshotTests/testIsAddingFirstPaymentMethod,StripePaymentSheetTests/PayWithLinkViewController_NewPaymentViewControllerSnapshotTests/testIsNotAddingFirstPaymentMethod' --retry-on-failure")
sh("./ci_scripts/test.rb --scheme '#{scheme}' --device '#{options[:device]}' --version #{options[:version]} --skip-snapshot-tests --retry-on-failure")
end
end
end
Expand Down
Loading