Skip to content

Delay display of continue state in FC #5628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Delay display of continue state in FC #5628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 30 additions & 22 deletions ...ions/StripeFinancialConnections/Source/Native/PartnerAuth/PartnerAuthViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,35 +311,43 @@ final class PartnerAuthViewController: SheetViewController {
)
return
}
let continueStateViews = ContinueStateViews(
institutionImageUrl: institution.icon?.default,
appearance: dataSource.manifest.appearance,
didSelectContinue: { [weak self] in
guard let self else { return }
self.dataSource.analyticsClient.log(
eventName: "click.apptoapp.continue",
pane: .partnerAuth
)
self.openInstitutionAuthenticationNativeRedirect(authSession: authSession)
},
didSelectCancel: { [weak self] in
guard let self else { return }
self.delegate?.partnerAuthViewControllerDidRequestToGoBack(self)
}
)
self.continueStateViews = continueStateViews
setup(
withContentView: continueStateViews.contentView,
footerView: continueStateViews.footerView
)

let setContinueState = { [weak self] in
// Update the view to indicate to the user that they can continue linking their bank account
// in their banking app. They shouldn't ever see this unless they exit their banking app and
// return to the merchant app.
guard let self else { return }
let continueStateViews = ContinueStateViews(
institutionImageUrl: institution.icon?.default,
appearance: dataSource.manifest.appearance,
didSelectContinue: { [weak self] in
guard let self else { return }
self.dataSource.analyticsClient.log(
eventName: "click.apptoapp.continue",
pane: .partnerAuth
)
self.openInstitutionAuthenticationNativeRedirect(authSession: authSession)
},
didSelectCancel: { [weak self] in
guard let self else { return }
self.delegate?.partnerAuthViewControllerDidRequestToGoBack(self)
}
)
self.continueStateViews = continueStateViews
self.setup(
withContentView: continueStateViews.contentView,
footerView: continueStateViews.footerView
)
}

subscribeToURLAndAppActiveNotifications()
UIApplication.shared.open(
url,
options: [.universalLinksOnly: true]
) { (didOpenBankingApp) in
guard !didOpenBankingApp else {
// we pass control to the bank app
// we did pass control to the bank app
setContinueState()
return
}
// if we get here, it means the banking app is not installed
Expand Down