Skip to content

Remove client-side country check for Link DOI #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+0 −6
Draft

Remove client-side country check for Link DOI #5481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a3599d
Remove client-side country check for Link DOI
tillh-stripe Sep 4, 2025
fcf3e08
Remove redundant test
tillh-stripe Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Stripe/StripeiOSTests/LinkSignupViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,6 @@ class LinkInlineSignupViewModelTests: STPNetworkStubbingTestCase {
XCTAssertNotEqual(sut.mode, .checkboxWithDefaultOptIn)
}

func test_defaultOptIn_not_allowed_outside_US() {
let sut = makeSUT(country: "CA", showCheckbox: true, allowsDefaultOptIn: true)
XCTAssertNotEqual(sut.mode, .checkboxWithDefaultOptIn)
}

func test_defaultOptIn_not_allowed_if_showing_checkbox() {
let sut = makeSUT(country: "US", showCheckbox: false, allowsDefaultOptIn: true)
XCTAssertNotEqual(sut.mode, .checkboxWithDefaultOptIn)
Expand Down
1 change: 0 additions & 1 deletion ...tSheet/StripePaymentSheet/Source/Internal/Link/ViewModels/LinkInlineSignupViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,6 @@ final class LinkInlineSignupViewModel {
if signupOptInFeatureEnabled && emailWasPrefilled {
self.mode = .signupOptIn
} else if showCheckbox {
let allowsDefaultOptIn = allowsDefaultOptIn && country == "US"
self.mode = allowsDefaultOptIn ? .checkboxWithDefaultOptIn : .checkbox
} else {
// If we don't show a checkbox *and* we have a prefilled email, show the phone field first.
Expand Down
Loading