Skip to content

Conversation

mats-stripe
Copy link
Collaborator

Summary

Adds the new StripeCryptoOnramp library to Package.swift for SPM support.

Motivation

SPM!!!

Testing

N/a

Changelog

N/a

@mats-stripe mats-stripe requested review from a team as code owners August 26, 2025 00:27
davidme-stripe
davidme-stripe previously approved these changes Aug 26, 2025
@mats-stripe
Copy link
Collaborator Author

Latest commit fixes an issue reported by the size report script:

[00:38:46]: ▸ /Users/vagrant/git/StripeCryptoOnramp/StripeCryptoOnramp/Source/Internal/API Bindings/STPAPIClient+CryptoOnramp.swift:52:104: error: cannot find type 'Calendar' in scope
[00:38:46]: ▸ func collectKycInfo(info: KycInfo, linkAccountInfo: PaymentSheetLinkAccountInfoProtocol, calendar: Calendar = .current) async throws -> KYCDataCollectionResponse {

davidme-stripe
davidme-stripe previously approved these changes Aug 26, 2025
@mats-stripe
Copy link
Collaborator Author

Latest commit includes some additional changes to properly release StripeCryptoOnramp as an SPM, and to hopefully fix the size report script.

Copy link

emerge-tools bot commented Aug 26, 2025

📸 Snapshot Test

Base build not found

No build was found for the base commit fc606ae. This is required to generate a snapshot diff for your pull request.

It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve.


🛸 Powered by Emerge Tools

@mats-stripe mats-stripe force-pushed the mats/add_onramp_sdk_to_spm branch 2 times, most recently from 51d1487 to e5e9d38 Compare August 27, 2025 21:52
@mats-stripe mats-stripe force-pushed the mats/add_onramp_sdk_to_spm branch from dbeda41 to 372eed0 Compare August 29, 2025 21:02
Copy link

⚠️ Public API changes detected:

StripePaymentSheet

- public var opensCardScannerAutomatically: Swift.Bool
- public var opensCardScannerAutomatically: Swift.Bool
- public var opensCardScannerAutomatically: Swift.Bool

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@mats-stripe mats-stripe enabled auto-merge (squash) August 29, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants