Skip to content

Conversation

dongjinleekr
Copy link
Contributor

Type of change

  • Documentation

Description

I found some problems while testing #11328.

20250416-120209

As you can see here, Map<String, Stack<ResourceItem>> is broken and being rendered incorrectly. (plus: tree → three (3))

20250416-120110

Also, the bullet list form is broken here.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@ppatierno ppatierno requested a review from a team April 16, 2025 06:23
@ppatierno ppatierno added this to the 0.46.0 milestone Apr 16, 2025
@ppatierno
Copy link
Member

@dongjinleekr you need to fix the DCO as it was asked on #11328 as well

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjinleekr dongjinleekr force-pushed the trivial/fix-testing-doc branch from 4f3284e to 7d19417 Compare April 16, 2025 12:04
@dongjinleekr
Copy link
Contributor Author

@ppatierno Here it is. I signed off and force-pushed.

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@im-konge im-konge merged commit 578aa87 into strimzi:main Apr 17, 2025
13 checks passed
@im-konge
Copy link
Member

Thanks for the PR @dongjinleekr :)

see-quick pushed a commit to see-quick/strimzi-kafka-operator that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants