Skip to content

Conversation

Kryptos-FR
Copy link
Member

PR Details

Recent refactorings broke the build of the launcher (see #2658 and #2683).

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the launcher to try this change out.

@Kryptos-FR Kryptos-FR self-assigned this May 12, 2025
@Kryptos-FR
Copy link
Member Author

Note: the build in TeamCity fails at the package signing step, though the compilation is green until then.

@Kryptos-FR Kryptos-FR requested a review from Eideren May 12, 2025 12:22
@Kryptos-FR Kryptos-FR merged commit 56e4fa5 into stride3d:master May 21, 2025
4 of 5 checks passed
@Kryptos-FR Kryptos-FR deleted the feature/launcher-build-fix branch May 21, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant