replace gopkg.in/yaml with github.com/goccy/go-yaml #1725
+11
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I get the point, removing support for old Go versions is something that should be stated by maintainer @dolmen @brackendawson |
|
Another PR was opened to address this apparently The kubernetes' yaml version doesn't imply to bump Go minimal version |
|
I also considered the Kubernetes yaml fork, but this one still has the 8 year old |
|
The tests are failing. I would say let's wait for a go/no-go from @dolmen or @brackendawson to bump minimal Go version for testify. I don't feel like there is an urge in fixing tests if your PR is declined because of the minimal Go version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
gopkg.in/yamlwithgithub.com/goccy/go-yaml. See #1724.This was previously attempted in #1120, but the PR got closed due to
go-yamlhaving a high number of dependencies. This has since been resolved.go-yamldoes not have any dependencies anymore.The only downside is that
go-yamlrequires at least golang v1.21