-
Notifications
You must be signed in to change notification settings - Fork 5
Browser source message #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed52aae to
f967fad
Compare
f967fad to
94a60bc
Compare
This reverts commit 414238e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a prototype bidirectional messaging system for browser sources, allowing communication between the OBS application and browser content. The implementation adds functionality to send messages from the app to browsers and receive messages from browsers back to the app.
- Adds messaging infrastructure with
MessageToBrowsermethod andmessagesToAppvector storage - Implements message handling through OBS source interface callbacks and process message handlers
- Enables remote debugging capabilities for browser instances
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| obs-browser-source.hpp | Adds message storage vector and MessageToBrowser method declaration |
| obs-browser-source.cpp | Implements MessageToBrowser method to dispatch JS events |
| obs-browser-plugin.cpp | Adds source callbacks for message handling and retrieval |
| cmake/os-windows.cmake | Contains duplicate message statement |
| browser-client.cpp | Adds messageToApp handler and debug logging |
| browser-app.cpp | Adds debugging port configuration and messageToApp function exposure |
Comments suppressed due to low confidence (1)
obs-browser-source.cpp:157
- This line appears to be orphaned code from a previous implementation and should be removed as it references an undefined variable 'async'.
if (!async) {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…bs/obs-browser into browser_source_message
New API to send messages between browser source and app.