Skip to content

Conversation

@summeroff
Copy link

@summeroff summeroff commented Jul 14, 2025

New API to send messages between browser source and app.

@summeroff summeroff changed the title Browser source message [Prototype] Browser source message Jul 14, 2025
@summeroff summeroff force-pushed the browser_source_message branch from ed52aae to f967fad Compare August 6, 2025 18:46
@summeroff summeroff force-pushed the browser_source_message branch from f967fad to 94a60bc Compare September 12, 2025 22:58
@summeroff summeroff requested a review from Copilot September 12, 2025 23:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a prototype bidirectional messaging system for browser sources, allowing communication between the OBS application and browser content. The implementation adds functionality to send messages from the app to browsers and receive messages from browsers back to the app.

  • Adds messaging infrastructure with MessageToBrowser method and messagesToApp vector storage
  • Implements message handling through OBS source interface callbacks and process message handlers
  • Enables remote debugging capabilities for browser instances

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
obs-browser-source.hpp Adds message storage vector and MessageToBrowser method declaration
obs-browser-source.cpp Implements MessageToBrowser method to dispatch JS events
obs-browser-plugin.cpp Adds source callbacks for message handling and retrieval
cmake/os-windows.cmake Contains duplicate message statement
browser-client.cpp Adds messageToApp handler and debug logging
browser-app.cpp Adds debugging port configuration and messageToApp function exposure
Comments suppressed due to low confidence (1)

obs-browser-source.cpp:157

  • This line appears to be orphaned code from a previous implementation and should be removed as it references an undefined variable 'async'.
		if (!async) {

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@summeroff summeroff changed the title [Prototype] Browser source message Browser source message Sep 15, 2025
@summeroff summeroff merged commit 1e56b6b into streamlabs Sep 15, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants