Skip to content

Open Vhost failed should return the real error which send from server. #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Open Vhost failed should return the real error which send from server. #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ func TestOpenFailedVhost(t *testing.T) {
}()

c, err := Open(rwc, defaultConfig())
if err != ErrVhost {
t.Fatalf("expected ErrVhost got: %+v on %+v", err, c)
if err == nil {
t.Fatalf("expected not nil error got: %+v on %+v", err, c)
}
}

Expand Down
2 changes: 1 addition & 1 deletion connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ func (c *Connection) openVhost(config Config) error {

if err := c.call(req, res); err != nil {
// Cannot be closed yet, but we know it's a vhost problem
return ErrVhost
return err
}

c.Config.Vhost = config.Vhost
Expand Down