Skip to content

Conversation

kanump
Copy link

@kanump kanump commented Jul 14, 2025

Description

fixes the issue with format_retrieve_response method to return whole response from memory(or knowledge base)

Related Issues

[Link to related issues using #issue-number format]

Documentation PR

[Link to related associated PR in the agent-docs repo]

Type of Change

  • Bug fix
  • New Tool
  • Breaking change
  • Other (please describe):

Testing

[How have you tested the change?] - Yes

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all

Checklist

  • I have read the CONTRIBUTING document

  • I have added tests that prove my fix is effective or my feature works

  • I have updated the documentation accordingly

  • I have added an appropriate example to the documentation to outline the feature

  • My changes generate no new warnings

  • Any dependent changes have been merged and published

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kanump kanump requested a review from a team as a code owner July 14, 2025 20:46
@kanump
Copy link
Author

kanump commented Jul 14, 2025

fix for #140

@JackYPCOnline
Copy link
Contributor

Thank you for your contribution! We truly appreciate community members like you taking the time to help improve the project.
I think this is a intended behavior here, if you want to retrieve full content, you might check retrieve tool

if len(text) > 150:
preview += "..."
result_text += f"\nContent Preview: {preview}"
# preview = text[:150]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe we can remove this preview completely instead of commenting here ^^

@kanump
Copy link
Author

kanump commented Sep 5, 2025

Thank you for your contribution! We truly appreciate community members like you taking the time to help improve the project. I think this is a intended behavior here, if you want to retrieve full content, you might check retrieve tool

@JackYPCOnline Thanks for your thoughtful response! While the retrieve tool could indeed serve as a viable alternative, I believe it's important that the memory.py tool provides complete retrieval responses. This would help prevent any potential confusion and ensure consistency in accuracy throughout the codebase.

Let me know your thoughts on this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants