feat!: use filepack format for encoding shards by default for uploadFile and uploadDirectory
#409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
changed the title
uploadFile and uploadDirectory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements storacha/RFC#65
This PR adds filepack data archive sharding as the default sharding format for
uploadFileanduploadDirectory. A filepack data archive is just the concatenated bytes of all blocks of the DAG. The index makes sense of the data. Using a filepack data archive saves space, making uploads faster as well as making retrievals faster, since file bytes are mostly contiguous within an archive.uploadCARstill uses the CAR sharder - I feel like uploading a CAR should always upload a CAR...🎥 Demo
BREAKING CHANGE: There is a small change to
upload/add. Previously it accepted only shards with the CAR IPLD codec, but now it also accepts shards with raw IPLD codec (i.e. filepack archives).Additionally
uploadFileanduploadDirectorywill use filepack format by default for shards. This behaviour is configurable - you can passsharder: (options) => new CARShardingStream(options)as an option in order to use the CAR sharder.