feat(formatters): add severity custom attribute to TeamCity inspections #2853
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vampire
force-pushed
the
add-severity-to-tc-inspections
branch
from
67fd7ed to
0bcde89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
Additional context
This PR adds the
SEVERITYcustom attribute to the inspection TeamCity service messages.It is true that this is just a custom attribute, but it the one shown as example in the TeamCity documentation,
and it also is just half-custom, because
SEVERITY="ERROR"is indeed considered by TeamCity when segregating the reported inspectinos into warnings and errors.