https://issues.redhat.com/browse/ACM-25011 #8321
Conversation
|
/cherrypick 2.14_stage (Ran this with Oliver to see if it would be recognized). |
|
@mletalie: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@fzdarsky, Could you please review this PR when you get a moment? Want to make sure the note I added (based on your comment in the JIRA ticket tied to this PR) as well as the command change is correct. Thanks! |
mletalie
changed the title
| FROM registry.redhat.io/rhel9/bootc-image-builder:latest | ||
| RUN subscription-manager repos --enable rhacm-<2.x>-for-rhel-<version>-$(uname -m)-rpms && \ | ||
| RUN dnf config-manager --set-enabled rhacm-2.14-for-rhel-9-x86_64-rpms && \ |
There was a problem hiding this comment.
maybe here we could keep the variables rhacm-<2.x> and rhel--$(uname -m)
edge_manager/edge_mgr_intro.adoc
Outdated
|
|
||
| See the following topics to learn more about using {rhem} on {acm-short}. All features are in *Technology Preview* status: | ||
|
|
||
| //ML comment |
There was a problem hiding this comment.
Don't forget to remove this
There was a problem hiding this comment.
Good catch, thanks!
governance/template_functions.adoc
Outdated
| - objectDefinition: | ||
| ... | ||
| data: <1> | ||
| data: # <1> |
There was a problem hiding this comment.
We don't usually have comments in code snippets, looks like this might have been added by accident? (since there aren't any comments)
There was a problem hiding this comment.
Actually, this was added on purpose b/c I was getting a lint break on call out #2 (although I didnt add that callout). I added it to call out #1 for conformity within the code, even though it wasn't necessary ( I could of added just to call out # 2). However, it had to be added to #2 b/c YAML parsers expect a newline immediately after a block scalar indicator (like >), or just whitespace and a comment. Adding a callout after > seems to produce a lint break. We can discuss further if needed. Thanks.
There was a problem hiding this comment.
I see, thanks for explaining. In that case, I'd maybe even consider not using callouts since we have to move away from them anyway for conversion. Let's bring this up to the team and see what the others say. Maybe @swopebe has some guidance here?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fzdarsky, mletalie, oafischer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dockerymick
changed the title
|
@mletalie: new pull request created: #8365 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick 2.14_stage |
|
@mletalie: new pull request could not be created: failed to create pull request against #2.14_stage from head openshift-cherrypick-robot:cherry-pick-8321-to-2.14_stage: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-8321-to-2.14_stage."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Have considered the checklist.
Issue: https://issues.redhat.com/browse/ACM-25011