File/Attachment context menu #479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2025 10:06
Works on Images, Videos and Audio files. I decided to leave out text files is because preferably we would use the browser's context menu for text selection. Signed-off-by: Amy <[email protected]>
download Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
insertish
requested changes
Oct 10, 2025
There was a problem hiding this comment.
I'm wondering whether the context menu should instead be implemented by extending the message context menu and adding the additional file property when right clicking on files only.
This will likely be more intuitive.
One change suggested, I think the above should be implemented instead as well.
added 4 commits
October 10, 2025 11:57
So we can display the message context menu + the attachment options
Signed-off-by: Amy <[email protected]>
The reason why is because Attachment is inside of TextEmbed, and passing the parent message through two components doesn't seem too efficient and might make merge conflicts. So we only show message options when message is passed to the context menu. Signed-off-by: Amy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
Brief overview of the changes
Nobody filed an issue, so this PR doesn't close anything.