Skip to content

Conversation

@acfoltzer
Copy link
Member

@acfoltzer acfoltzer commented Sep 30, 2025

Non-working branch for #204, updated for the new repo structure and crankshaft changes. Until work resumes, we should not expect this branch to work, but keeping it compiling will reduce the churn when we do return to it.

The crankshaft changes are tracked here: stjude-rust-labs/crankshaft#59

For all contributors:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have added an entry in the CHANGELOG (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).
  • You have either (a) made a PR to the next branch in the sprocket.bio repository [if you are a Sprocket team member] or (b) have suggested any changes you think need to be made to sprocket.bio in the description of your PR [if you are an external contributor].

For PRs containing lint rule changes:

  • You have updated any and all effected entries within RULES.md.
  • You have added a test case in crates/wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.

I've been doing some lightweight editing in-place on the HPC, but need to get this into git both to avoid losing progress and to be able to edit in a friendlier setting
easier to debug container inaccessibility of inputs and outputs locally rather than on the HPC
I have fairly low confidence in the correctness of this merge, but this at least gets everything
compiling in the context of the new `sprocket` repo and with the substantial changes to
`crankshaft`. We should now be able to run tests to figure out what broke when we properly return to
landing the generic backend.
claymcleod pushed a commit to claymcleod/sprocket that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants