Skip to content

Conversation

@raman976
Copy link

@raman976 raman976 commented Oct 9, 2025

Fix Issue #398: Failed jobs display as 'completed' instead of 'failed'

This PR addresses Issue #398 where failed tasks were incorrectly showing as "completed" in progress reporting across all execution backends. The fix ensures consistent behavior and provides better visibility into task failures during workflow execution.

Related Issue: Fixes stjude-rust-labs/sprocket#398

Changes Made

TES Backend Fix: Updated Crankshaft submodule to point to fork with fix for State::ExecutorError returning correct error status

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

Copy link
Contributor

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raman976. Unfortunately these changes are not correct.

A TES task that fails with an EXECUTOR_ERROR status is not considered a failed task by Crankshaft. Crankshaft should only return an error if there was a problem in the execution of the task.

It is up to the user of Crankshaft to treat a non-zero exit as a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed jobs show up as "completed"

2 participants