Allocate classwrapper mpy types on heap instead of statically #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces the statically allocated
mp_obj_full_type_t typeby a staticmp_obj_full_type_t* type_ptrwith heap allocated data.This is a patch in a set to enable allocating all micropython-wrap data on the micropython-heap, to avoid using the STL allocator, further allowing micropython-wrap to be run on a microcontroller environment.
This specific change is required because the
typeneeds to be allocated on the micropython-heap to correctly prevent contained pointers to be collected, if they are on the mpy heap as well. In an upcoming PR it shall be possible to choose either STL or mpy allocated types via compiler definition.Related: #16
This patch should not change behaviour at all.
It was locally tested using the test-suite.