ENH: Add support for PCPUs #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 111
Lines 4111 4147 +36
=========================================
+ Hits 4111 4147 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Identified an inconsistency, debugging, draft for now |
It's just been combined into the existing VCPUs field + more aliases adding
Addition of pcpus to vcpus is backwards-compatibile
Member
Author
|
Fixed: small typo from vscode autocomplete autocompleting the wrong variable |
anish-mudaraddi
approved these changes
Oct 2, 2025
gmatthews20
requested changes
Oct 7, 2025
Comment on lines
+117
to
+121
| HypervisorProperties.VCPUS: lambda a: a.usage.vcpus + a.usage.pcpus, | ||
| HypervisorProperties.VCPUS_AVAIL: lambda a: a.usage.vcpus_avail | ||
| + a.usage.pcpus_avail, | ||
| HypervisorProperties.VCPUS_USED: lambda a: a.usage.vcpus_used | ||
| + a.usage.pcpus_used, |
Collaborator
There was a problem hiding this comment.
I don't know if we should be combining PCPU and VCPU like this since they are two different resources in openstack, its only our specific use case where we only use PCPUs that we run into this issue. I'd suggest return separate fields for PCPU and VCPU and let the users of the library decided how to handle them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just been combined into the existing VCPUs field + more aliases adding
Tested on dev: Works. No longer do hypervisors show 0 vCPUs