Skip to content

Decouple execution of roles #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from
Draft

Decouple execution of roles #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b74f2f
Use tag to decouple roles execution
jose-caballero Aug 14, 2025
0d0bdc7
Update README to document usage of tags
jose-caballero Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ sudo snap install helm --classic
- `effect`: Whether to schedule on node if key taint not matched. Usually: `NoSchedule`
</p>
- `commands`: The commands (git clones) to run on the deployed instances/images
7. Run the playbook: `ansible-playbook deploy_jhub.yml`
7. Run the playbook:
- To run the entire playbook: `ansible-playbook deploy_jhub.yml`
- To run only the deploy_hub role: `ansible-playbook deploy_jhub.yml --tags deploy_hub`
- To run only the deploy_jhub role: `ansible-playbook deploy_jhub.yml --tags deploy_jhub`
Comment on lines +101 to +102
Copy link
Contributor

@meoflynn meoflynn Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a sentence for each role about what they do (as they have very similar names)

Copy link
Contributor Author

@jose-caballero jose-caballero Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this?

  • To only run the role that creates the kubernetes cluster: ...
  • To only run the role that set the JupyterHub stuff: ...

But with proper sentences?

Copy link
Contributor

@meoflynn meoflynn Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, however both roles however are separate from creating the kubernetes cluster (see #39 (comment)). I think we need to review the roles and see whether we need to rename the roles to make them clearer on what they do, or combine them into one role.

Copy link
Contributor Author

@jose-caballero jose-caballero Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to merge them?
The whole point of decoupling their execution was to prevent a long wait (helm tasks?) when we only want to add a new username or something trivial like that.

Now, you have more experience than me. If that is never the case, and potential delays are minimal and acceptable, then this PR is not relevant, irrespective we merge the roles or not.

Up to you.

Copy link
Member

@AlexCK-STFC AlexCK-STFC Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meoflynn @jose-caballero is this PR still active?

Copy link
Contributor Author

@jose-caballero jose-caballero Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. We are waiting to see what happens with the entire service. Depending on that, this may still be needed or can be deleted. So let's keep it for now as it is.


## Customising your jupyterhub deployment
These are settings/variables to chagne/add to customise your jupyterhub deployment, and are optional.
Expand Down
6 changes: 4 additions & 2 deletions deploy_jhub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
- hosts: all # Kubectl is configured from this machine
roles:
- deploy_jhub
tags:
- deploy_jhub
- deploy_hub


tags:
- deploy_hub