3189 sympy handling equal #3191
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3191 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 376 376
Lines 53156 53161 +5
=======================================
+ Hits 53104 53109 +5
Misses 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The link check failure is because of https://www.khronos.org/files/opencl22-reference-guide.pdf, which I just manually tested and it seems to work now. This is basically ready for review, but it must run the full CI (since previously logical comparisons using I hit that problem when inlining (for my training), and it converted the condition pointed out in #3189 to a This PR is blocking #1623 for that reason. |
| def test_sympy_writer_logicals(fortran_reader: FortranReader, | ||
| fortran_expr: str, | ||
| sympy_str: str): | ||
| '''Test handling of user-defined types, e.g. conversion of |
There was a problem hiding this comment.
Not the fault of this PR but I've just noticed that this docstring is wrong :-)
| is .NEQV.''' | ||
| return f"({'.NEQV.' .join(self._print(i) for i in expr.args)})" | ||
|
|
||
| def _print_Equality(self, expr): |
There was a problem hiding this comment.
Please could you add -> str to all of these handlers.
There was a problem hiding this comment.
Done - I tried to look at what expr is, but that appears to be not straight forward, and I didn't want to dive any further into SymPy ... so I left them :) I also disabled two pylint warnings.
|
Updated to latest master. I will trigger the CI on Monday. |
|
CI passed. |
A small change to fix #3189 by converting Fortran
==into SymPyEq(...).