Skip to content

Fix diff buffer window management to preserve layout #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix diff buffer window management to preserve layout #27

wants to merge 2 commits into from

Conversation

@stevemolitor
Copy link
Owner

@stevemolitor stevemolitor commented Sep 26, 2025

Summary

This PR addresses issue #24 where diff buffers were disrupting the window layout by replacing existing windows instead of creating new ones.

Changes

  • Added inhibit-same-window parameter to both default and tab-specific display configurations
  • Removed display-buffer-pop-up-frame to prevent disorienting frame creation
  • Modified display-buffer actions in monet.el:1328 and monet.el:1344

Expected Behavior

  • Diff buffers now create new windows instead of reusing existing ones
  • Original window layout is preserved during diff operations
  • No new frames are created (stays within current frame)
  • Window layout remains intact after diff resolution

Testing

  • Test with multiple edit cycles to ensure window layout stability
  • Verify diff buffers appear in new windows
  • Confirm original buffers return after diff resolution

Fixes #24

@stevemolitor
Fix line number reporting when narrowing is in effect
98b3012
@stevemolitor
Improve diff buffer window management
787e119 
- Add inhibit-same-window parameter to prevent reusing current window
- Remove display-buffer-pop-up-frame to avoid disorienting frame creation
- Ensures diff buffers create new windows instead of replacing existing ones
- Helps preserve original window layout during diff operations

Fixes #24
@stevemolitor stevemolitor marked this pull request as ready for review September 26, 2025 01:38
@stevemolitor stevemolitor mentioned this pull request Sep 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A diff edit replaces and then closes an open window

2 participants

@stevemolitor