Remove duplicate Types and provide a way to change Type Labels per-WritingStrategy #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are effectively the same, and if needed a custom config can be used to re-label it.
bordoni
approved these changes
Dec 2, 2025
estevao90
approved these changes
Dec 3, 2025
nikolaystrikhar
approved these changes
Dec 3, 2025
Contributor
Author
|
Intentionally not merging this just yet. @nikolaystrikhar and I are discussing possible alternatives. |
d4mation
changed the title
fixed type and keep fixStill some config-related ones, but they'll be easiest to fix while writing new tests
d4mation
commented
Dec 4, 2025
Comment on lines
+22
to
+26
| keepachangelog: { | ||
| feature: "Added", | ||
| fix: "Fixed", | ||
| tweak: "Changed", | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Only keepachangelog needs labels different than the global/default ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Loom TBA