Skip to content

services/galexie: Build and push galexie images on master commits #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

services/galexie: Build and push galexie images on master commits #5837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca8afc1
Build and push galexie images on master commits
travertischio Oct 23, 2025
50bd6d5
Merge branch 'master' into build-galexie-master
travertischio Oct 23, 2025
35b047d
add core version on master builds
travertischio Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/galexie-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,9 @@ jobs:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Push to DockerHub
- name: Push version tag to DockerHub
run: make -C services/galexie docker-push

- name: Push latest tag to DockerHub
if: ${{ ! contains(github.ref, '-rc') }}
run: make -C services/galexie docker-push-latest
24 changes: 22 additions & 2 deletions .github/workflows/galexie.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
pull_request:

jobs:
galexie:
run-integration-tests:
name: Test ${{ matrix.storage_type }} integration
runs-on: ubuntu-22.04
strategy:
Expand Down Expand Up @@ -53,4 +53,24 @@ jobs:

- name: Run tests - ${{ matrix.storage_type }} integration
run: |
go test -v -race -run "TestGalexie${{ matrix.storage_type }}TestSuite" ./services/galexie/...
go test -v -race -run "TestGalexie${{ matrix.storage_type }}TestSuite" ./services/galexie/...

build-and-push-container-image:
name: Build and Push Container Image
runs-on: ubuntu-22.04
needs: run-integration-tests
if: github.ref == 'refs/heads/master'
steps:
- name: Build docker
env:
STELLAR_CORE_VERSION: 24.0.0-2802.0d7b4345d.focal
run: make -C services/galexie docker-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what stellar-core version is this docker image built with? you’ll need to set STELLAR_CORE_VERSION.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

35b047d


- name: Login to DockerHub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Push to DockerHub
run: make -C services/galexie docker-push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to periodically clean up those docker images we push on every master commit? They’re going to pile up. Have we considered pushing them to a private docker repo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will definitely be pushing more images than we are right now
setting up automatic pruning in docker hub for this repository sounds like something we might do in the future

here is a link to some discussions that pushed us to use the public dockerhub repo in the design doc for these changes
https://docs.google.com/document/d/1dDRf6VCS_4iizjD_y4sKcPoHOh99-0jBDtn4rXdKrN8/edit?disco=AAABsNvBkAA

8 changes: 4 additions & 4 deletions services/galexie/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ docker-build:
--build-arg GOFLAGS="-ldflags=-X=github.com/stellar/go/services/galexie/internal.version=$(VERSION)" \
$(if $(STELLAR_CORE_VERSION), --build-arg STELLAR_CORE_VERSION=$(STELLAR_CORE_VERSION)) \
-f services/galexie/docker/Dockerfile \
-t $(DOCKER_IMAGE):$(VERSION) \
-t $(DOCKER_IMAGE):latest .
-t $(DOCKER_IMAGE):$(VERSION) .

docker-clean:
$(SUDO) docker stop fake-gcs-server || true
Expand Down Expand Up @@ -42,6 +41,7 @@ docker-test-fake-gcs: docker-clean

docker-push:
$(SUDO) docker push $(DOCKER_IMAGE):$(VERSION)
ifneq ($(findstring -rc, $(VERSION)), -rc)

docker-push-latest:
$(SUDO) docker tag $(DOCKER_IMAGE):$(VERSION) $(DOCKER_IMAGE):latest
$(SUDO) docker push $(DOCKER_IMAGE):latest
endif
1 change: 0 additions & 1 deletion services/galexie/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,3 @@ COPY --from=builder /go/bin/galexie /usr/bin/galexie
ENTRYPOINT ["/usr/bin/galexie"]

CMD ["--help"]

Loading