Poc/shared lib #2073
Draft
Poc/shared lib #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds verify account drawer and uses drawer in send and swap flows * removes debug stub for hasPrivateKey * renames VerifyAccountDrawer * tweak styles for rounded borders in drawer * uses pxToRem util for border radius
* adds useGetAppData hook to fetch account and settings data * removes loadAccount and loadSettings thunks * moves app data fetching to top level route data hooks * wip, refactors setup sign flow hook to be consumed by view data hooks * wip, adds re-route check to sign workflows * wip, adds re-route check to history flow * moves app data fetching to individual view hooks * removes public and private key wrappers * wip - restores unit tests with new mocks for account data * adds app data to all top level route components data hooks * restores unit tests for sign tx, grant access * restores Account unit tests * adds cache option to useGetAppData hook * adds location hook to all top level route components * restores account switching in sign flows, fixes related tests * moves updating app data to view data hooks in account and signing flows * fixes switch account unit tests * adds getAppData mocks to remaining tests * updates login helpers to use base route now tied to account view * moves signing flow hook into view bodies for signing components * replace test ID derived from old account route * moves connected account settings references to data hook references * use correct signing functions for auth entry, reverts account mismatch changes * removes unneeded sub entry check when calculating balances in send flow * restores overwriting account warning in account creator * increase timeout for payments tests * pulls out onboarding reroute logic into helper * fetch connected dapps after removing selections * remove stray log * reorganize imports in AddAsset component * fixes stale networkDetails in useAssetHook * checks app state in data hook in account creator instead of relying on a query parameter * pulls out signing flow account selector handling into shared helper * use account selector helper in sign tx data hook * adds test for abandoned onboarding routing * adds unlock account routing test * adds e2e test to assert balances change when accounts change * adds unit test for switching accounts during signing flow * use API mock tests last
* fix signAuthEntry return based on version * add types for response queue * roll back up version bump
…2044) * fix signAuthEntry return based on version * roll back up version bump * make sure to close request access window when chaining api methods
* adds caches for balances and icons, uses them in sendAmount data hook * adds icon cache from balances data hook * adds home domain cache, uses it in useGetAssetDomainsWithBalances hook * caches token lists, use getBalances hook to fetch destination balances * renames new slice to cache slice * adds tests for all uses of cache slice in reducers * refactors useGetBalances use of cache * clears token list cache when new list is added * removes unused var in test * uses new instance of get balances hook for destination balances * handle missing destination balances for contract accounts in transaction detail
* add slight timeout for e2e tests * rm only
* don't hide send/swap buttons for suspicious assets * don't show swap button for soroban tokens with 0 balance * add test
…itial recent address lookup in send to component (#2052)
…end flow (#2062) * adds info tooltip for the available balance amount in the send flow * adds tooltip info to translations * Added translations
* fetch discover results and show apps in UI * add tests * update url * rollback unrelated change * use type narrowing and adjust to API payload * Added translations * add legal copy * Added translations * update discover icon to be more prominent
* update beta to use new BE beta url * fix broken test
* use prod BE for all routes except Discover endpoint * use separate indexer url for v2 * add v2 URL for test runners * rm force for token payment test * rm more force's
piyalbasu
commented
May 21, 2025
| const paymentDifference = _isRecipient ? "+" : "-"; | ||
| const formattedAmount = `${paymentDifference}${formatAmount( | ||
| new BigNumber(startingBalance).toString(), | ||
| )} ${destAssetCode}`; |
There was a problem hiding this comment.
we can get rid of all this formatting logic and just use what comes back from the shared lib
piyalbasu
commented
May 21, 2025
| {_isRecipient && <Icon.Plus />} | ||
| {/* When you've sent XLM to create external account */} | ||
| {!_isRecipient && <Icon.ArrowUp />} | ||
| <ActionIconComponent /> |
There was a problem hiding this comment.
we just need to handle some markup around showing the appropriate icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.