feat!: a new token list approach - wallet sdk token lists integration #6912
+6,609
−33,298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
changed the title
saledjenic
changed the title
Jenkins BuildsClick to see older builds (73)
|
saledjenic
changed the base branch from
develop
to
chore/single-token-manager
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
3 times, most recently
from
5fdbea8 to
119e1b7
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
from
119e1b7 to
9e2a878
Compare
saledjenic
commented
Sep 9, 2025
| @@ -131,3 +131,6 @@ pkg/sentry/SENTRY_PRODUCTION | |||
| # Don't ignore generated files in the vendor/ directory | |||
| !vendor/**/*.pb.go | |||
| !vendor/**/migrations.go | |||
| services/wallet/token/local-token-lists/default-lists/status.go | |||
There was a problem hiding this comment.
We don't need to store initial token lists in the repo. They will be fetched on every build (maybe we should do some smarter approach like download only if there are no local lists or the forceDownload flag is true, by default don't download).
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
4 times, most recently
from
13ad01f to
c54bd12
Compare
saledjenic
commented
Sep 11, 2025
| @@ -179,7 +179,7 @@ status-go-deps: | |||
|
|
|||
|
|
|||
|
|
|||
| statusgo-library: generate | |||
| statusgo-library: generate download-tokens | |||
There was a problem hiding this comment.
saledjenic
commented
Sep 11, 2025
| @@ -43,6 +43,7 @@ in pkgs.buildGoPackage { | |||
| pushd go/src/$goPackagePath | |||
| go run cmd/library/*.go > $NIX_BUILD_TOP/main.go | |||
| make generate SHELL=$SHELL GO111MODULE=on GO_GENERATE_CMD='go generate' | |||
| make download-tokens SHELL=$SHELL GO111MODULE=on | |||
There was a problem hiding this comment.
We should always download initial tokens when building on CI.
saledjenic
changed the title
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
2 times, most recently
from
bdcad51 to
41cffc7
Compare
saledjenic
force-pushed
the
feat/new-token-list-approach
branch
from
41cffc7 to
96dc9bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Changes:
GetTokenByChainAddressGetTokensByChain(chainID uint64) []*tokenlists.TokenGetTokensByChains(chainIDs []uint64) ([]*tokenlists.Token, error)GetAllTokens() []*tokenlists.TokenGetTokenList(id string) (*tokenlists.TokenList, bool)GetAllTokenLists() []*tokenlists.TokenListGetLastTokenListsRefreshTime() (int64, error)API changes:
GetTokenListdoesn't returnListWrapperbut[]*tokenlists.TokenListGetTokensremovedGetCustomTokensremoved