-
Couldn't load subscription status.
- Fork 49
change the names of several components #1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3cf515 to
56b3ffd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anatgstarkware reviewed 39 of 48 files at r1, 2 of 4 files at r2, all commit messages.
Reviewable status: 41 of 48 files reviewed, 4 unresolved discussions (waiting on @gilbens-starkware)
stwo_cairo_prover/crates/common/casm_registry.json line 2 at r2 (raw file):
{ "air_version": "c68bb12a",
This should have changed
Code quote:
c68bb12astwo_cairo_prover/crates/cairo-air/src/components/mod.rs line 100 at r2 (raw file):
.join("\n") } pub mod call_opcode_abs;
Please move up
stwo_cairo_prover/test_data/test_prove_verify_all_opcode_components/all_opcode_components.cairo line 60 at r2 (raw file):
jump_abs_double_deref(); // jump_opcode_abs
Any idea what this comment is?
stwo_cairo_verifier/crates/cairo_air/src/components/sample_evaluations.cairo line 1 at r2 (raw file):
// AIR version c68bb12a
This should have changed
Code quote:
c68bb12a56b3ffd to
bf4e51b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 41 of 48 files reviewed, 4 unresolved discussions (waiting on @anatgstarkware and @gilbens-starkware)
stwo_cairo_prover/crates/cairo-air/src/components/mod.rs line 100 at r2 (raw file):
Previously, anatgstarkware (anatg) wrote…
Please move up
Done.
stwo_cairo_prover/crates/common/casm_registry.json line 2 at r2 (raw file):
Previously, anatgstarkware (anatg) wrote…
This should have changed
Done.
stwo_cairo_prover/test_data/test_prove_verify_all_opcode_components/all_opcode_components.cairo line 60 at r2 (raw file):
Previously, anatgstarkware (anatg) wrote…
Any idea what this comment is?
not sure.
stwo_cairo_verifier/crates/cairo_air/src/components/sample_evaluations.cairo line 1 at r2 (raw file):
Previously, anatgstarkware (anatg) wrote…
This should have changed
Done.
de18702 to
997a7e9
Compare
997a7e9 to
12ca186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anatgstarkware reviewed 4 of 48 files at r1, 4 of 7 files at r3, 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
stwo_cairo_prover/test_data/test_prove_verify_all_opcode_components/all_opcode_components.cairo line 60 at r2 (raw file):
Previously, ohad-nir-starkware (Ohad Nir) wrote…
not sure.
Please take care of it in a different pr
This change is