Skip to content

Conversation

@ohad-nir-starkware
Copy link
Collaborator

@ohad-nir-starkware ohad-nir-starkware commented Oct 22, 2025

This change is Reviewable

@ohad-nir-starkware ohad-nir-starkware self-assigned this Oct 22, 2025
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/components_name_changes branch 2 times, most recently from b3cf515 to 56b3ffd Compare October 26, 2025 18:18
Copy link
Contributor

@anatgstarkware anatgstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anatgstarkware reviewed 39 of 48 files at r1, 2 of 4 files at r2, all commit messages.
Reviewable status: 41 of 48 files reviewed, 4 unresolved discussions (waiting on @gilbens-starkware)


stwo_cairo_prover/crates/common/casm_registry.json line 2 at r2 (raw file):

{
  "air_version": "c68bb12a",

This should have changed

Code quote:

c68bb12a

stwo_cairo_prover/crates/cairo-air/src/components/mod.rs line 100 at r2 (raw file):

        .join("\n")
}
pub mod call_opcode_abs;

Please move up


stwo_cairo_prover/test_data/test_prove_verify_all_opcode_components/all_opcode_components.cairo line 60 at r2 (raw file):

    jump_abs_double_deref();

    // jump_opcode_abs

Any idea what this comment is?


stwo_cairo_verifier/crates/cairo_air/src/components/sample_evaluations.cairo line 1 at r2 (raw file):

// AIR version c68bb12a

This should have changed

Code quote:

c68bb12a

@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/components_name_changes branch from 56b3ffd to bf4e51b Compare October 27, 2025 09:07
Copy link
Collaborator Author

@ohad-nir-starkware ohad-nir-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 41 of 48 files reviewed, 4 unresolved discussions (waiting on @anatgstarkware and @gilbens-starkware)


stwo_cairo_prover/crates/cairo-air/src/components/mod.rs line 100 at r2 (raw file):

Previously, anatgstarkware (anatg) wrote…

Please move up

Done.


stwo_cairo_prover/crates/common/casm_registry.json line 2 at r2 (raw file):

Previously, anatgstarkware (anatg) wrote…

This should have changed

Done.


stwo_cairo_prover/test_data/test_prove_verify_all_opcode_components/all_opcode_components.cairo line 60 at r2 (raw file):

Previously, anatgstarkware (anatg) wrote…

Any idea what this comment is?

not sure.


stwo_cairo_verifier/crates/cairo_air/src/components/sample_evaluations.cairo line 1 at r2 (raw file):

Previously, anatgstarkware (anatg) wrote…

This should have changed

Done.

@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/components_name_changes branch 2 times, most recently from de18702 to 997a7e9 Compare October 27, 2025 18:20
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/components_name_changes branch from 997a7e9 to 12ca186 Compare October 28, 2025 13:36
Copy link
Contributor

@anatgstarkware anatgstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@anatgstarkware reviewed 4 of 48 files at r1, 4 of 7 files at r3, 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)


stwo_cairo_prover/test_data/test_prove_verify_all_opcode_components/all_opcode_components.cairo line 60 at r2 (raw file):

Previously, ohad-nir-starkware (Ohad Nir) wrote…

not sure.

Please take care of it in a different pr

@ohad-nir-starkware ohad-nir-starkware merged commit 65e84ba into main Oct 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants