-
Notifications
You must be signed in to change notification settings - Fork 49
Fix nightly ci. #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix nightly ci. #1433
Conversation
3d6d6b8 to
225db21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successful run: https://github.com/starkware-libs/stwo-cairo/actions/runs/18708818397/job/53352139779
(compilation used to fail and now it passed, tests are not done yet.)
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Gali-StarkWare)
225db21 to
77dd624
Compare
77dd624 to
864eb64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gali-StarkWare reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
.github/workflows/nightly.yaml line 25 at r1 (raw file):
uses: software-mansion/setup-scarb@v1 with: scarb-version: "2.12.2"
Wait, that's not the prover's version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
.github/workflows/nightly.yaml line 25 at r1 (raw file):
Previously, Gali-StarkWare wrote…
Wait, that's not the prover's version
nevermind I see it was like this before, just something to think about
This change is