Skip to content

Conversation

@gilbens-starkware
Copy link
Collaborator

@gilbens-starkware gilbens-starkware commented Oct 22, 2025

This change is Reviewable

Copy link
Collaborator Author

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful run: https://github.com/starkware-libs/stwo-cairo/actions/runs/18708818397/job/53352139779
(compilation used to fail and now it passed, tests are not done yet.)

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Gali-StarkWare)

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Gali-StarkWare reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


.github/workflows/nightly.yaml line 25 at r1 (raw file):

        uses: software-mansion/setup-scarb@v1
        with:
          scarb-version: "2.12.2"

Wait, that's not the prover's version

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)


.github/workflows/nightly.yaml line 25 at r1 (raw file):

Previously, Gali-StarkWare wrote…

Wait, that's not the prover's version

nevermind I see it was like this before, just something to think about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants