- 
                Notifications
    You must be signed in to change notification settings 
- Fork 49
Add export preprocessed roots dev util. #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add export preprocessed roots dev util. #1420
Conversation
| 
 This stack of pull requests is managed by Graphite. Learn more about stacking. | 
9eb24f9    to
    caa421c      
    Compare
  
    caa421c    to
    ca50dde      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware)
stwo_cairo_prover/crates/prover/src/witness/preprocessed_trace.rs line 21 at r2 (raw file):
{ let preprocessed_trace = preprocessed_trace.to_preprocessed_trace();
This was a very heated debate among the old team and we decided to have an empty line before a new "section" but we can reopen this discussion lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alon-f reviewed 2 of 7 files at r1, 5 of 5 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @anatgstarkware and @gilbens-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @gilbens-starkware)
stwo_cairo_prover/crates/dev_utils/src/lib.rs line 1 at r2 (raw file):
pub mod preprocessed_roots;
How about moving this code to prover/utils?
Code quote:
pub mod preprocessed_roots;
This change is