Skip to content

Conversation

@gilbens-starkware
Copy link
Collaborator

@gilbens-starkware gilbens-starkware commented Oct 15, 2025

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gilbens-starkware gilbens-starkware marked this pull request as ready for review October 15, 2025 08:52
@gilbens-starkware gilbens-starkware force-pushed the 10-15-add_export_preprocessed_roots_dev_util branch from 9eb24f9 to caa421c Compare October 15, 2025 10:28
@gilbens-starkware gilbens-starkware force-pushed the 10-15-add_export_preprocessed_roots_dev_util branch from caa421c to ca50dde Compare October 15, 2025 11:09
Copy link
Contributor

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware)


stwo_cairo_prover/crates/prover/src/witness/preprocessed_trace.rs line 21 at r2 (raw file):

{
    let preprocessed_trace = preprocessed_trace.to_preprocessed_trace();

This was a very heated debate among the old team and we decided to have an empty line before a new "section" but we can reopen this discussion lol

Copy link
Contributor

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alon-f reviewed 2 of 7 files at r1, 5 of 5 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @anatgstarkware and @gilbens-starkware)

Copy link
Contributor

@anatgstarkware anatgstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @gilbens-starkware)


stwo_cairo_prover/crates/dev_utils/src/lib.rs line 1 at r2 (raw file):

pub mod preprocessed_roots;

How about moving this code to prover/utils?

Code quote:

pub mod preprocessed_roots;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants