Skip to content

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Nov 17, 2025

This change is Reviewable


Note

Converts the repo from a workspace to a single Scarb package and updates CI/codecov paths and the flow-test checker accordingly.

  • Build/Config:
    • Replace workspace Scarb.toml with single-package config in root ([package], [dependencies], [dev-dependencies], [[target.starknet-contract]], tests, features, fmt, profiles).
    • Remove workspace/apps/staking/contracts/Scarb.toml.
  • CI:
    • Update Codecov path from workspace/apps/staking/contracts/coverage/coverage.lcov to coverage/coverage.lcov in .github/workflows/on-pull-request.yaml.
  • Scripts:
    • Adjust scripts/check_all_flows_have_test.py to use repo root as CONTRACTS_FOLDER instead of workspace/apps/staking/contracts.

Written by Cursor Bugbot for commit fad9926. This will update automatically on new commits. Configure here.

Copy link
Collaborator Author

arad-starkware commented Nov 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arad-starkware arad-starkware mentioned this pull request Nov 17, 2025
@arad-starkware arad-starkware self-assigned this Nov 17, 2025
@arad-starkware arad-starkware marked this pull request as ready for review November 17, 2025 12:47
@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from d2569df to 7a22829 Compare November 17, 2025 12:55
@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from 7a22829 to 8dc8afc Compare November 17, 2025 12:56
Base automatically changed from arad/ci_add_pr_ci to main November 17, 2025 13:08
@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from 8dc8afc to e497862 Compare November 17, 2025 13:10
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@0d4c1ff). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage        ?   95.38%           
=======================================
  Files           ?       45           
  Lines           ?     9337           
  Branches        ?        0           
=======================================
  Hits            ?     8906           
  Misses          ?      431           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from e497862 to fad9926 Compare November 17, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants