refactor(byte_array): delegate ByteArray iterator into ByteSpan iterator

[giladchase]

Faster than current approach, which uses at.

[reviewable-StarkWare]

This change is 

[giladchase]

• refactor(sha256): Compute ByteArray sha256 via iterator #8540
• refactor(byte_array): delegate ByteArray iterator into ByteSpan iterator #8539 👈 (View in Graphite)
• feat(byte_array): add ByteSpan iterator #8530
• feat(byte_array): add get(usize) and index(usize) to ByteSpan #8427
• feat(ops): add get, SliceIndex and impl for ByteSpan #8417 : 1 other dependent PR (#8511 )
• feat(byte_array): add ByteSpan::to_byte_array #8416
• refactor(byte_array): extract ByteArray::append logic #8486
• feat(byte_array): add ByteArray::span and Span::len #8329
• refactor(test): remove fixed-size bytearray testutils #8343
• refactor(test): remove compare_spans util #8342
• refactor(test): remove compare_byte_array util and rework tests #8336
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[orizi]

@orizi reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

corelib/src/byte_array.cairo line 570 at r1 (raw file):

impl ByteArrayIterator of crate::iter::Iterator<ByteArrayIter> {
    type Item = u8;
    #[inline]

no need.
let the system do that.

Code quote:

    #[inline]

[orizi]

@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase and @TomerStarkware)

[giladchase]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

---

corelib/src/byte_array.cairo line 570 at r1 (raw file):

Previously, orizi wrote…

no need.
let the system do that.

It doesn't inline it :(
When I remove #[inline] test_into_iterator goes up by ~20K gas

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

@orizi reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

@orizi reviewed 1 of 1 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

@orizi reviewed 1 of 1 files at r11, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

@orizi reviewed 1 of 1 files at r12, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

@orizi reviewed 1 of 1 files at r13, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

@orizi reviewed 1 of 1 files at r14, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[graphite-app]

Merge activity

• Oct 22, 11:55 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.