-
Couldn't load subscription status.
- Fork 638
Using MiMallocator for better performance #8534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using MiMallocator for better performance #8534
Conversation
68b52f2 to
4160337
Compare
4160337 to
98a154e
Compare
5f73e2a to
8d434f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 20 of 22 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
a discussion (no related file):
Seems CI is still degraded.
8d434f3 to
fee15ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 3 of 23 files at r4, all commit messages.
Reviewable status: 4 of 24 files reviewed, 2 unresolved discussions (waiting on @eytan-starkware and @giladchase)
crates/bin/starknet-sierra-extract-code/src/main.rs line 11 at r4 (raw file):
#[cfg(feature = "mimalloc")] #[global_allocator] static GLOBAL: MiMalloc = MiMalloc;
does this work instead of the use?
cleaner if under cfg.
Suggestion:
#[global_allocator]
static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;fee15ae to
b54bee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 24 files reviewed, 2 unresolved discussions (waiting on @giladchase and @orizi)
a discussion (no related file):
Previously, orizi wrote…
Seems CI is still degraded.
Now under a feature flag
crates/bin/starknet-sierra-extract-code/src/main.rs line 11 at r4 (raw file):
Previously, orizi wrote…
does this work instead of the
use?
cleaner if under cfg.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 24 of 24 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @giladchase)

TL;DR
Added mimalloc as the global allocator for all Cairo binaries to improve memory management.
What changed?