fixed sierra gen revcation of const aliases #8526
Open
+58
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
TomerStarkware
force-pushed
the
tomer/sierra-gen-constants
branch
from
ae4c93a to
8a4d442
Compare
orizi
requested changes
Oct 15, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions
crates/cairo-lang-sierra-generator/src/local_variables.rs line 117 at r1 (raw file):
} struct VarSource {
doc.
crates/cairo-lang-sierra-generator/src/local_variables.rs line 119 at r1 (raw file):
struct VarSource { variable_id: VariableId, allow_const: bool,
maybe?
Suggestion:
allowed_as_const: bool,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.