Renamed DiagnosticLocation to SpanInFile.
#7909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dean-starkware
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @maciektr)
Additionally moved it to filesystem crate, and made it a part of a parent of virtual file.
orizi
force-pushed
the
orizi/add-parent-file-full-origin
branch
from
d9bef52 to
8c651ee
Compare
dean-starkware
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally moved it to filesystem crate, and made it a part of a parent of virtual file.