create a separate go module for the site builder #869
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkotik can you please look into why tests are no longer running? |
Dear @bencroker, I did when I submitted this PR. I got stuck a bit. This was my fix attempt: 56dfbd5 I am not familiar enough with how the site builder runs to figure out what is wrong with the smoketests. I can try again, perhaps later. @delaneyj could you perhaps assist? |
|
Please update or close this based on #871. |
|
Will get it done tonight by creating a new go.mod file within the #871 new directory. |
|
Continued here: #874 <- this way is better when what I was doing above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes pull request #826 by removing unnecessary dependencies for
optional template engines.
The module was named
sitebuilderinstead ofsitebecause the lattercreates an ambigous import. It can be fixed later, after the SDK import
is bumped to the latest version.