Skip to content

Add X-Accel-Buffering to Python SDK #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Laurent2916
Copy link

@Laurent2916 Laurent2916 commented Apr 15, 2025

to prevent nginx from buffering stuff

@bencroker
Copy link
Collaborator

Seems like a good idea. @lllama ?

@bencroker bencroker changed the title add X-Accel-Buffering to python sdk SSE_HEADERS Add X-Accel-Buffering to Python SDK Apr 15, 2025
@bencroker
Copy link
Collaborator

Still waiting on a review from @lllama...

@bencroker bencroker added the sdk SDK related issues label Apr 29, 2025
@lllama
Copy link
Contributor

lllama commented Apr 29, 2025

Hmm. I think there was discussion on Discord that we'd avoid adding specific headers in the SDKs. Do we know if the other SDKs are adding this?

@bencroker
Copy link
Collaborator

The PHP SDK uses this as a default header, and the Ruby one too, so I think it depends on how common it is to use nginx with Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk SDK related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants